Results 60 comments of Sam Partington

If anyone wants a bit of context on Output Walkers, https://github.com/whiteoctober/Pagerfanta/issues/220 may help.

I'm afraid I don't understand Doctrine's internals well enough to explain this issue, sorry! @akorz I think you may be on the right lines when you say it's due to...

Thanks for the input, @butkoNix. @ahmed-bhs, did this solve your problem?

Hi @CoalaJoe. There's no "get page number" method built into the adapters, I'm afraid. You'd need to run a custom query for this. I don't have time to work out...

Hi @winter7621, It looks like Sylius itself exposes an option for you in its routing configuration: http://docs.sylius.org/en/latest/bundles/SyliusResourceBundle/index_resources.html#changing-the-max-per-page-option-of-paginator For example (from their docs linked to above): ``` # app/config/routing.yml app_book_index_top: path:...

Hi @crowd-studio, thanks for the PR. I'm not sure that the original is wrong, though. The point of the original is that 1 is a valid page (regardless of the...

Hi again, The case of the page number being less than 1 is already covered by the `checkCurrentPage` function (see [here](https://github.com/whiteoctober/Pagerfanta/blob/master/src/Pagerfanta/Pagerfanta.php#L239)), which is called before the function you've changed. You...

Sorry, I'm still confused by your example. You claim that you're passing in a value of `2` and that `NbPages` is `5`. Consider the code at present: `$currentPage > 1...

Thanks for this. I'll review it once the TODOs are complete.

Hi @tfe2012, thanks for commenting! Unfortunately, we don't have capacity to add an additional adapter for a technology that we're not needing ourselves, but anyone is welcome to submit a...