Sam O'Connor

Floating point numbers in doc strings cause method error

8

Somehow the dollar amounts in the docstring below get parsed as floats and lead to a method error for `mdflatten` (and `mdconvert`). ```julia """ ## `BonusAmount::String` -- *Required* The Bonus...

Test "CONNECT_WITH_BODY_REQUEST" maybe worng

1

See: https://github.com/nodejs/http-parser/pull/235#issuecomment-356903686 The `CONNECT_WITH_BODY_REQUEST` test case input has `Content-Length: 10` and a body `"blarfcicle"`, but the test expects [`.body= ""`](https://github.com/nodejs/http-parser/blob/master/test.c#L1102) ! [The RFC says](https://tools.ietf.org/html/rfc7230#section-3.3): > _The presence of a message...

Document URI(uri::URI; kw...)

1

JuliaWeb/HTTP.jl#203 https://github.com/JuliaWeb/HTTP.jl/blob/8dc959efa622e373caa46fad8f8cfa9f7a9fc359/src/URIs.jl#L75-L81

POST operations need to handle intermittent network failure.

5

The GitHub doc [says](https://developer.github.com/v3/?#http-verbs) that they have been careful to use HTTP methods with semantics appropriate to the API operations. HTTP.jl retries most request automatically in the event of network...

WIP: Lazy Parsing

5

This branch adds a number of modules (with passing tests) but does not integrate them into the HTTP request/response processing code. Lazy parsing has potential performance and security benefits for...

Revisit src/precompile.jl

7

[`src/precompile.jl`](https://github.com/JuliaWeb/HTTP.jl/blob/master/src/precompile.jl) is currently empty. Maybe resist this to see if load times can be improved. Or, maybe not, if there is not much of a load-time issue anyway https://github.com/JuliaWeb/HTTP.jl/issues/147. Having...

Set JULIA_HOME?

1

In a statically compiled program `Base.julia_cmd()` seems to use the directory of the static executable as the path to the `julia` executable. To work around this I've added `-DJULIA_HOME=$JULIA_HOME` to...

What is the best (standard?) way to detect a `static-julia` build ? Perhaps there should be `Base.is_static_julia() -> Bool` ? I currently have the following at the bottom of my...

Applying the correctness tests in LazyJSON.jl/test/runtests.jl to JSON2 reveals some issues with UTF-16 parsing. e.g. ```julia github.com/nst/JSONTestSuite.JSON2.jl: Test Failed at /Users/sam/.julia/dev/LazyJSON/test/runtests.jl:442 Expression: jparse("[\"\\uD834\\uDd1e\"]") == Any["𝄞"] Evaluated: Any["頴訊"] == Any["𝄞"] github.com/nst/JSONTestSuite.JSON2.jl:...

Parsing json_checker.json fails

1

https://github.com/samoconnor/LazyJSON.jl/blob/master/test/json_checker.json ```julia julia> using JSON2 julia> x = JSON2.read(String(read("json_checker.json"))) ERROR: ArgumentError: JSON invalid escape character: '/' Stacktrace: [1] unescape(::String) at /Users/sam/.julia/packages/JSON2/Fw6eK/src/strings.jl:140 [2] read(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Type{String}) at /Users/sam/.julia/packages/JSON2/Fw6eK/src/strings.jl:182 [3] read(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Type{Any}) at...