Sam Dotson

Thanks for looking over my PR. > contrary to physical units that unyt focuses on, conversion factors between currency units are not constants. This is true, and I completely agree...

Thanks, @chrishavlin. Treating monetary units as dimensionless enables most of the functionality with unyt, except for a few important features (IMO): 1. dimension validation (as you mentioned) 2. cannot use...

Just to provide some more context for this feature, I am developing a set of packages for energy system planning and analysis. Enabling dimension validation with currencies and parsing from...

Thanks @ngoldbaum! Personally, I'm leaning towards blocking currency conversion entirely because it's easier to implement and maintain and is more robust. With respect to engineering calculations, it's much more common...

@ngoldbaum this PR now includes - tests for currency creation and conversion - blocks currency conversion between currencies (allows dollars -> cents and vice versa)

It's been a few weeks, just checking on the status of this pull request. Thanks!

I see that I misunderstood your initial comments. The solution that I implemented was that users are simply not allowed to convert among units with dimensions of currency (with tests...

Okay, I can definitely include the `add_currency` feature you're requesting. For clarification, I understood a "list of known currencies" to mean some set of pre-defined common currencies (e.g. dollars, euros)....

@ngoldbaum thank you for continuing to engage with this PR. I think having an API such as the `add_currency` you describe is good for handling the unique challenges of currency...

Update: Strangely, the solution I had previously ```py sys.path.append(os.path.join(os.path.dirname(sys.path[0]), 'data_processing')) ``` No longer works. Additionally, the current path append ```py sys.path.append(os.path.join(os.getcwd(), 'data_processing')) ``` does not work either. The current working...