Sameh Abouel-saad

I see defined `EntryGot` event not emitted from anywhere. should be removed if not used. https://github.com/threefoldtech/tfchain/blob/49973fcfaeb7b7332ec645290164db5d6912b992/substrate-node/pallets/pallet-kvstore/src/lib.rs#L40

The following link provides a general overview of the code documentation guidelines that are recommended for Substrate projects: https://github.com/paritytech/substrate/blob/master/docs/DOCUMENTATION_GUIDELINES.md One of the sections that is especially important for [pallet development](https://github.com/paritytech/substrate/blob/master/docs/DOCUMENTATION_GUIDELINES.md#pallet-crates)...

refactor: Billing refactor

3

## Description This PR addresses several issues and introduces significant changes to the billing in the pallet-smart-contract module. Here are the key changes and the issues they resolve: ### High-Level...

During the grace period, the NU consumption may be incorrectly accumulated

1

During the grace period, the NU consumption may be incorrectly accumulated because: - The NU consumption is read and added to the contract's amount due, but the unbilled consumption is...

Refactor/remove lock balance logic in billing flow

2

Choosing between locking and distributing less frequently, or not locking and distributing more frequently could be debatable as both actions require modifications to the account balances storage, which involves computational...

Regarding the billing system's business requirements, I would like to highlight three points that may need adjustments: **Grace Period Billing:** When a node contract enters a grace period, the workload...

Instrumentation: Refactor billing logic to improve auditability and log all major steps

1

Currently, a lot of billing logic is hidden inside a black box. We don't have enough logs to audit any abnormal behavior in contract billing. Also, Things like overflowed calculations...

Can't fork main net using fork-off-substrate tool

4

## Describe the bug Can't fork main net network using [fork-off-substarte tool](https://github.com/threefoldtech/tfchain/blob/development/docs/development/fork-off-substrate.md). ## Logs `Substrate RPC : Response too big, Exceeded max limit of 15728640` ## Additional context The tool...

Going through the code, certified capacity should cost 25% more here https://github.com/threefoldtech/tfchain/blob/5a9ad375cb3cfa637ab51b7494d0680fc78d405c/substrate-node/pallets/pallet-smart-contract/src/cost.rs#L328-L334 But I can see that the DIY type is hardcoded here, We are not getting it from the...

Staking Discount Miscalculation Due to Per-Contract Discount Application

3

## Description The staking discount is intended to reward users with a discount based on their total balance and the duration they can run a contract. However, the current implementation...