Sameh Abouel-saad

Results 44 issues of Sameh Abouel-saad

Check that all nodes in that farm has no active node contracts. Should first reason about the benefits of having this and how expensive regarding call weight

On devnet, I noticed that a `RefundTransaction` is present in both `RefundTransactions` and `ExecutedRefundTransactions`. This is unexpected because we remove the transaction from the `RefundTransactions` storage map before inserting it...

type_bug

## Describe the bug see: https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1790 Currently we allow same farm name but in a different case to be inserted https://github.com/threefoldtech/tfchain/blob/36c891c02a1758a6bd6769357fdef230886940ff/substrate-node/pallets/pallet-tfgrid/src/farm.rs#L31-L34 https://github.com/threefoldtech/tfchain/blob/36c891c02a1758a6bd6769357fdef230886940ff/substrate-node/pallets/pallet-tfgrid/src/farm.rs#L55

type_bug

## Describe the bug Many calls in pallets do not sufficiently check the validity of the input parameters, which can lead to DoS of the system for some time. Recently,...

type_bug

## Describe the bug Currently, all network validators are required to have offchain worker enabled. This is because we depend on the best block number in retrieval contracts ids from...

This issue reported by @hossnys Enabling debug logs is not possible using the values file.

type_feature

Check if we can now remove our fork of substrate-validator-set pallet

type_feature

The document [here](https://github.com/threefoldtech/tfchain/blob/33855091d89ac3173aea7145bc96acaa661b88d4/docs/misc/adding_validators.md?plain=1#L52) refer to the smct key type requirement which already removed [here](https://github.com/threefoldtech/tfchain/pull/558) Also should point to the importance of enabling offchain worker on all the validators

documentation

Emitting too much information in events can be wasteful and inefficient, as it may consume unnecessary on-chain storage space. Currently, we emit the value alongside the account id and user...

type_feature

https://github.com/threefoldtech/tfchain/blob/9d56a805ead04d7f5d49cd7387443535a66e4032/bridge/tfchain_bridge/pkg/stellar/stellar.go#L351-L386 Instead of using a for loop to send requests and wait for 10 seconds when no new transactions are found, we can use the Stellar [SDK](https://github.com/stellar/go/blob/master/clients/horizonclient) stream mode to...

type_feature