Alexander Makarov comments

Results 1744 comments of


                                            Alexander Makarov

Redis driver reserved id repush to wating list before delete

$ttr passed at https://github.com/yiisoft/yii2-queue/blob/master/src/cli/Command.php#L185 is a string while it should be int. Any idea why?

Redis driver reserved id repush to wating list before delete

How would you solve it, @sanwv?

Fix build

Partially fixed but still won't mind help with the rest of failure cases.

Fix build

https://github.com/yiisoft/yii2-queue/runs/3983065809?check_suite_focus=true#step:3:2627 seems signals test is unstable.

Fix build

Restarted 2 latest runs.

Fix build

Seems fails are totally random :( ``` 1) tests\drivers\amqp_interop\QueueTest::testSignals Failed asserting that 1 matches expected 129. ``` 1 is SIGHUP. No idea why it happens.

The queue task was delayed in ttr seconds

Does that happen with any task every time? In order to fix an issue we need to somehow reproduce it.

The queue task was delayed in ttr seconds

That should be connected.

Calling deleteAll() after modifying a PrimaryKey definition cannot delete old data

@haohetao do you have time for a pull request with some tests (and possibly a fix)?

Feature requests: \yii\data\DataFilter accept filter in JSON format

Looks interesting. Do you want to make it optional?