Alexander Makarov
Alexander Makarov
@fl0v do you mean MySQL driver of mutex extension? If so, it should be fixed there instead of in queue, right?
@hunwalk solution provided isn't finished.
@nadar does this PR fix it?
@nadar no, that shouldn't be the same thing.
So... does the change from this PR fix the problem?
Closing because of such testing results. @erickskrauch thanks for testing it.
Still errors: ``` ❯ ./build/build fix-links PHP Warning 'yii\base\ErrorException' with message 'Undefined array key "http://www.yiiframework.com"' in /Users/samdark/src/yii2/build/helpers/LinkChecker.php:72 Stack trace: #0 /Users/samdark/src/yii2/build/helpers/LinkChecker.php(72): yii\base\ErrorHandler->handleError(2, 'Undefined array...', '/Users/samdark/...', 72) #1 /Users/samdark/src/yii2/build/helpers/LinkChecker.php(37): yii\build\helpers\LinkChecker->checkUrl('http://www.yiif...') #2...
It takes forever to check all links but it seems it works. There are some issues though: 1. https://www.yiiframework.com/extension/yiisoft/yii2-twig/doc/guide/ is replaced with https://www.yiiframework.com/extension/yiisoft/yii2-twig/doc/guide/2.4/en/. First link always leads to latest version....
Judging on these, I'm not sure it's a good idea to add it to pipeline to automatically fix things.
Yes, dropping extra things could be implemented. These will likely vary per database.