Alexander Makarov
Alexander Makarov
We are running tests with older PHPUnit, patched version: https://github.com/yiisoft/yii/blob/master/composer.json#L101 PHP 8 is already checked and pass: https://github.com/yiisoft/yii/runs/2676270735
> And this should not break production code as these two classes are only used in tests. Well, it is likely that it will affect someone's tests. > I think...
A decision for release could be made by answering two questions: 1. It it making things better? 2. Does it break existing things? If the answers are "yes" and "no"...
Well, I'm not really sure it's needed. It seems adding it mades iPad scrolling a bit better but since it doesn't solve the issue with iPad completely, I think we...
Да, можно сделать. Если есть время — делайте pull request, замёржу...
Хм... с какого коммита?
Да, похоже. Доку надо поправить, но времени сейчас в обрез :( Если сделаете pull request — с удовольствием смёржу.
I don't remember but guess it's to compensate scrollbar width.
Got that from Alexey Matveed via email. Not verified: ``` javascript if (!localOptions.cloning) { overlay.data(pluginNamespace+'.el', el); $(el).data(pluginNamespace+'.parent', $(el).parent()); openedModalElement = $(el).appendTo(overlay).prepend($('').attr('tabindex', "-1")).show(); } else { openedModalElement = $(el).clone(true).appendTo(overlay).prepend($('').attr('tabindex', "-1")).show(); }...
Cannot be done w/o breaking existing code. Will consider it for 1.0.0.