Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

http://localhost/ is not valid url for UrlValidator

As @cebe said, that's a special case and there's a way to make it work by adjusting regular expression. Not going to change it.

http://localhost/ is not valid url for UrlValidator

@Radon8472 correct.

http://localhost/ is not valid url for UrlValidator

Adding it as an option disabled by default is fine.

Way to add error with custom value path

What's the use-case?

Add file validator for out of the box solution.

1. It should work w/ `UploadedFileInterface` from PSR-7. 2. May support multiple uploads for the same field.

Add file validator for out of the box solution.

Since there's no PSR-7 dependency in this package, it might be worth having it elsewhere.

Add domain rule

Need option to support wildcards. Could be done with filter_var: ```php if ($allowWildcard) { $host = str_replace('*', 'wildcard', $host); } if (!filter_var($host, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { // invalid } ```

Add type to incorrect input messages

@cebe what do you want to do with these errors? Would you somehow handle it differently from the rest of validation errors? Would you hide these from end users?

Add more shortcuts?

I'd like to collect real feedback first.

Separate technical and non-technical error messages

I see two potential outcomes: 1. We won't translate such messages always returning these in English. That's less work for translators but is questionable by itself. What if that's API...