Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

SessionMiddleware can not work on swoole

Wait, but `$requestSessionId` is obtained from request and you have different request object every time, don't you? ```php $requestSessionId = $this->getSessionIdFromRequest($request); ```

SessionMiddleware can not work on swoole

You're right. Any fix that comes in mind? I don't currently have Swoole environment set up :(

SessionMiddleware can not work on swoole

1. Added resetter config. 2. Updated https://github.com/yiisoft/docs/blob/master/guide/en/tutorial/using-yii-with-swoole.md @ChisWill ping us if it doesn't help please.

Introduce request body modifiers

That would be convenient.

Why does method RequestModelFactory::getRequestData() return an array and not a DTO?

What's the benefit of using DTO here?

The "_complete" command gets into the debugger

How do you configure shell autocompletion? Do you have a reliable way to reproduce it?

Extract rule name and options to separate collector

1. As an author of the custom rule, what would be different for me to implement / use the rule? 2. What if I want to ship it in a...

Extract rule name and options to separate collector

I like the ability to configure it, but I don't think we need to separate this information, since it logically belongs to rule itself.

Return error code for API application

Would you please elaborate with some example? It's not clear now.

Return error code for API application

I see. That makes sense if client needs to handle errors of a kind in a special way.