Sam Chung

Results 83 comments of Sam Chung

Might wait to merge alongside https://github.com/seek-oss/skuba/pull/1537

Safe to merge, so just going to do it

~Bundle with: https://github.com/seek-oss/skuba/pull/1655#issuecomment-2339627360~

https://github.com/seek-oss/eslint-config-seek/pull/136 Typescript Eslint added support in 7.0.0. Pending seek config changes we should look to migrate by creating a patch

Can we delete https://github.com/seek-oss/skuba/blob/3310e6ed714cd4b06b03890c5c900e33b20b9ab9/src/cli/lint/autofix.ts#L74 if it lands?

Not entirely sure this would help us move away from configs? The `group` step doesn't pass on any attributes down to children the last time I checked when it was...

Last I attempted to migrate, vitest does not support CJS mocks which means we would have to migrate to ESM https://github.com/seek-oss/skuba/issues/398 before this.

This is probably a better idea over overloading package.json. Additionally we can also provide some typing for the config

We don't currently run anything on the said repo 😅 I was looking to run that and a test deploy after running skuba configure

> To tangent even harder, IIRC it's currently difficult/impossible to _exclude_ files like your own meta `pipeline.yml` from the clone performed by `skuba init`. Lots of work to do 🙂...