Sam Chung

Results 83 comments of Sam Chung

You might be able to piggy back off sam-cli images? eg. https://hub.docker.com/r/amazon/aws-sam-cli-emulation-image-nodejs14.x https://hub.docker.com/r/amazon/aws-sam-cli-emulation-image-python3.9 https://gallery.ecr.aws/sam/emulation-python3.9

What if you wanted to set the field to undefined? Eg. If the type is X | undefined

Yeah we might be able to support this when I find time to do https://github.com/floydspace/serverless-esbuild/issues/269

Okay looks like #269 might not be related to this one after all. Turns out the symlink pattern isn't supported in Lambda anyway so we'd need to use `--shamefully-hoist` for...

Okay update on this. I simply don't have time. Too much going on at work and other factors. If anybody wants to have a go, I'll see what I can...

probably because of ESM/CJS issues. Think esbuild plugins may be expected in CJS

Hey have you seen how we're asking you to set it up in the documentation? That might solve your issue https://github.com/floydspace/serverless-esbuild#esbuild-plugins

Ah I think I know the issue but won't have much time this week https://github.com/floydspace/serverless-esbuild/blob/dc3c6848b35cc711c130cb80c99e3e4b04eaa828/src/helper.ts#L83 This needs the `exclude` list.

I'd have to test this but I believe this line here: https://github.com/floydspace/serverless-esbuild/blob/fbf213d47a700debd15202e3f59f852b8edfe2a1/src/helper.ts#L92 you could add an or condition here to return if it's in the exclude list.

Oh I see because you are not using package individually.