Sam Chung

Results 83 comments of Sam Chung

I would assume it's because we may only run the packagerOptions scripts once?

We do an analysis of your individual zips and try to only pack those dependencies. Is there a reason you're marking pg-native with exclude?

I don't think I can quite help you here without a sample repo? Can you produce something minimal for me to look at?

Yeah that makes sense - when I did this I didn't realise that esbuild pivots on more based on the platform. Also, at the time esm was still very experimental

This seems more an issue with the esbuild plugin than us. We don't control how the sourcemaps or breakpoints work especially in conjunction with a plugin. We just wrap the...

I think if a comprehensive list of what needs to be covered (usecases/scenarios) is provided, it might make it easier for people to contribute to some unit tests? As it...

I had a little think about this - maybe if we don't get unit test coverage we can at least setup some integration tests with snapshots. Anybody have a good...

I've created a library heavily based on this which will allow you to do this: https://github.com/samchungy/fastify-zod-openapi. It uses my zod-openapi library under the hood

Can ship this along with https://github.com/seek-oss/skuba/pull/1487

> Is it soon enough to require node 20? 18's got over a year left Ah dang never noticed v23. V22 is 18 so we can at least bump it...