Sam Chung

We just do some very basic logic here. Always happy to accept PRs for improvements https://github.com/floydspace/serverless-esbuild#esbuild-plugins https://github.com/floydspace/serverless-esbuild/blob/dc3c6848b35cc711c130cb80c99e3e4b04eaa828/src/index.ts#L167

Yeah I think it was because of performance reasons, in particular if users are copying in `node_modules` which can contain a ridiculous ammount of files or they could have big...

Thanks for the hard work 🙇

Just dropping this issue here in case someone asks about this. We are still waiting on Jest to fully support ESM https://github.com/facebook/jest/issues/9430

> Hi @clawsl, I am also having the same issue currently even with the latest version 1.28.0. I am also using the individually package option. plugins: > > * serverless-esbuild...

Hey @yuejun92 my capacity is pretty limited right now. I'll try take a look this weekend or maybe some time after work. Thanks for the repo.

I had a quick look and it's likely because your package pattern intersects the handler's. Could be an easy fix but I'll have a suss another time

Here's what I think is happening: - We tell esbuild to bundle `./vc-insuance/V1/insuance.handler`. - We copy it into your bundle at the same path ./vc-insurance/V1/insurance.js - We look at your...

So the way that esbuild works with bundle: true is that it will bring all the files it needs into itself into one entrypoint you specify. In this case it...

> Hi @samchungy, after i remove the package from the function, it's working now. I wonder if the plugin should ignore same file name or ignore the package all together...