Sam Chung

Results 83 comments of Sam Chung

Should be resolved by https://github.com/floydspace/serverless-esbuild/pull/337

> I'm having the same issue, but with 1.32.5 which should include #337 > > At the time `getBuildOptions()` runs, `this.outputWorkFolder` and `this.outputBuildFolder` are undefined, so this line https://github.com/floydspace/serverless-esbuild/blob/master/src/index.ts#L245 puts...

nx appears to require this particularly when running lint over subdirectories. Should we respect the subdirectories' own configuration, eg. eslintrc, prettierrc etc? ![image](https://github.com/seek-oss/skuba/assets/18017094/daa34ccb-5625-41d2-b227-b93fd20c017c)

Yeah I can't see us implementing something this specific just for Serverless Offline. Ideally the Serverless Offline environment should match the Prod environment as closely as possible. You could probably...

Work to auto login to ECR is complete: https://github.com/SEEK-Jobs/build-agent-images/pull/174

Are you using include patterns? With default Serverless you need to use patterns whereas with this we bring in what you need unless it's some external binary/file you reference dynamically...

Can you look inside the zip for any info on what's different between the two? It's difficult to speculate based on your screenshots.

Hmm doesn't invoke local immediately invoke the function? How would a watch function work here? Would you want it to immediately be invoked? With serverless-offline, correct me if I'm wrong...

Wait for downstream to support: https://github.com/typescript-eslint/typescript-eslint/issues/8211

It's likely that the zod instance your schema was written in may have been created using a different version of zod. The tsc compiler doesn't do too well in that...