Sam Saccone
Sam Saccone
yes, that is exactly how i ended up doing it, just a touch ugly
https://github.com/jnicklas/capybara/pull/911
Weird we do not have any tests for this, we should add one :)
@buob lets add a console.warn under the old method and simply have it proxy to the new method to alert people to change their code so that this can be...
http://nodejs.org/api/console.html#console_console_warn_data
Ah this sounds great @jaridmargolin ! great call
Yes a callback is the correct javascript term here. @tomhicks you are spot on, thanks for the response :)
for example ``` js this.waitUntil(function() { return x.read('zap'); }, function(result){ return result.length > 4 //can return a promise also }, , ) ``` or perhaps another syntax would be ```...
Been working through a few failures lately and my current thinking is to add something like ``` foo.isVisible().until(true, ).then(...) foo.isVisible().until(function(){return }).then(...) foo.isVisible().untilDoesNotThow( ).then(...) ``` what do you think @tomhicks
@tomhicks that looks correct.. @moimikey let me know if this is still not working for you