pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

Published 20 hours ago • verified publisher icon mojotech

Rename `submitSelector` to `findSubmit`

Open buob opened this issue 10 years ago • 5 comments

Finishes #247

buob avatar Sep 11 '14 18:09 buob

Coverage Status

Coverage remained the same when pulling d7f960c5f0c93f9104d1f10da0ee73883f07b447 on jb/rename-submit-selector into 8ab8fc52da525108404c02d47a301a52ab4cccbb on master.

coveralls avatar Sep 11 '14 18:09 coveralls

Weird we do not have any tests for this, we should add one :)

samccone avatar Sep 14 '14 00:09 samccone

@buob lets add a console.warn under the old method and simply have it proxy to the new method to alert people to change their code so that this can be "non" breaking

samccone avatar Dec 30 '14 14:12 samccone

console.warn("Deprecated, bro. :facepunch:")

sethkrasnianski avatar Dec 30 '14 14:12 sethkrasnianski

http://nodejs.org/api/console.html#console_console_warn_data

samccone avatar Dec 30 '14 14:12 samccone