Sam Richards

Results 145 comments of Sam Richards

Ultimately I suspect this is an issue with the fact that the site is not server-side rendered. We need dynamic tags (so that every page doesn't have the same title...

More on this: - https://stackoverflow.com/questions/59222217/twitter-card-meta-tags-work-in-index-html-not-in-react-helmet - https://dev.to/zorfling/can-i-use-react-helmet-to-add-social-card-meta-tags-for-twitter-and-facebook-4a36

FYI @wackerow - perhaps a good one to pair on with @corwintines or @pettinarip next time we need to add a language 😄

@hwwhww @CarlBeek do you believe this PR is still relevant? Or should we close this out?

Related to #448

@wackerow can we close this out? I believe these TODOs have been completed.

Great thanks @wackerow - please link the relevant PRs to this issue 😄

Hey @veridelisi - looks like this is being addressed in #7921

I tried to explain the issue description but let me know if you have any specific questions.

Thanks for raising this! Agree would be great to land on a consistent approach. No strong opinion here. I just ask that we add this to the style guide once...