ethereum-org-website icon indicating copy to clipboard operation
ethereum-org-website copied to clipboard

Ensure consistent spelling of 'zk-rollup' across the site

Open hursittarcan opened this issue 3 years ago • 3 comments

Describe the bug

We currently use different ways of spelling 'zk-rollup' on the website - specifically 'ZK-rollup' & 'zk-rollup'. The spelling should be consistent across the website.

To reproduce

  • Example 'ZK-rollup':

image

  • Example 'zk-rollup':

image

Expected behavior

I'm not sure about the preferred spelling, I believe 'zk-rollup' - all lowercase looks best (unless it's used in the beginning of a sentence).

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

hursittarcan avatar Sep 18 '22 18:09 hursittarcan

AFAIK, it's ZK-rollups right? I could find and replace all of those

yadunandanbhat avatar Sep 19 '22 06:09 yadunandanbhat

I'm not sure. Maybe it's best if we wait for a reply from the core team.

hursittarcan avatar Sep 19 '22 09:09 hursittarcan

Thanks for raising this! Agree would be great to land on a consistent approach.

No strong opinion here. I just ask that we add this to the style guide once we decide 😄: https://ethereum.org/en/contributing/style-guide/

samajammin avatar Sep 19 '22 10:09 samajammin

I can't actually find the example for zk-rollup and I would suggest to leave it with ZK-rollup

julian-st avatar Oct 02 '22 07:10 julian-st

We'd like to go with ZK-rollup across the site 👍 Some context: https://github.com/ethereum/ethereum-org-website/issues/7123

minimalsm avatar Oct 03 '22 16:10 minimalsm

Closing as PR has been merged

corwintines avatar Oct 03 '22 18:10 corwintines