Sam McCall

@kadircet the bug is in https://reviews.llvm.org/D75446, but I'm having trouble (re)understanding the intuition behind that patch in order to repair it. Maybe you can help me out? --- Minimal example...

OK, this was quite an adventure. I learned new stuff about SourceLocations, which is ... not reassuring, after such a long time! https://reviews.llvm.org/D134618 has a fix. The "last token" problem...

LSIF has all the same limitations and more (and is IIUC quite bulky for a full codebase!). Conceptually LSIF is at the wrong abstraction level to use as an index...

The example code is missing `#include `. The logs are truncated, and don't match the example given. ``` code":"pp_file_not_found","message":"'gui_thread.hpp' file not found" ``` this indicates you have an `#include` that...

Generally, clangd aims for compatibility with the C-family languages clang supports, and to parse args the same way. If mainline clang supports hip files, would it make sense to have...

Yes, what Nathan said. > Why this feature is so complicated? A few main reasons: - clangd relies heavily on the preamble optimization: splitting the file in two parts which...

> Clangd does not currently work for unity builds (see e.g. #147 (comment)). Right, but if you have self-contained files, you don't *have* to always do a unity build with...

Hmm, we can't tell if you want to call the function or not: e.g. `&foo(n)` is correct if foo returns a reference and you want a pointer. Even in C:...

Ah, thanks! That makes sense, and yeah either replacing with spaces (and a hilarious comment) or cutting off parsing seems reasonable. --- I was thinking about whether `#ifdef` header guards...

Yeah, as I feared, zeroing out the rest of the preamble file instead of truncating fixes `#pragma once` but leaves `#ifdef` broken. EmitData in ASTWriter sees ControllingMacro=0 ControllingMacroID=0 when writing...