Sam McCall

Results 207 comments of Sam McCall

I don't think MS is likely to fix this. I think we should probably add an extension client capability to control the behavior and set it in the VSCode plugin....

Thanks for looking into making this more friendly! I'm not really sure about this approach, for a few reasons: 1: Flags are specific to a clangd version, but the extension...

I really like how straightforward and declarative this approach is. The reliance on another extension means we'll only benefit people who happen to have that installed, I suppose. But I...

> The clangd feature to prompt you when clangd.path or clangd.arguments is overridden (added March 2021) predates Workspace Trust (added in vscode 1.57, released May 2021). Right. It was triggered...

It doesn't actually watch for changes in an event-driven way, but rather looks for updates when the compile command is fetched (e.g. because the file has changed and we're reparsing...

> User edits the file (perhaps trivially) and saves it. The save is not necessary - the edit will cause that file's diagnostics to be updated. Saving any file will...

Or put .clang-format in your home directory?

That patch is tempting, it's not obvious what the right pattern is. Sent https://reviews.llvm.org/D134243, which is a maybe-slightly-clearer way to get the same thing.

Yup. This is not designator-specific: ``` #define X 2, 3, 4 int m(int a, int b, int c); int n = m(X); // a:b:c:X ```

Thanks for the example & reduction, can repro. Further minimized: ``` int foo(int x); #define FOO(X) foo(X) #define INDIRECT FOO(2) auto x = /*spurious x:*/INDIRECT; ``` I think the new...