Salvatore Martire
Salvatore Martire
There's something strange with the repo IMHO. master uses `sofa/eloquence-metable:5.5` but the tag 5.6 uses `sofa/eloquence-metable:5.6` Isn't master supposed to have the latest changes? 🤔
/backport to stable31
> Please update PR title and description to the actual content change Done
/backport to stable32
Hi @provokateurin thank you for your review! I'm sorry my first commit was hard to review. I wanted to keep the refactoring in one commit, but I see that it...
@provokateurin I finally managed to finish and push the updated/new tests 🎉 I decided to edit the get/list ones, since the test code would be not too complex, but added...
Hey @provokateurin thanks again for the loops of review! I addressed everything up to your latest comments but I noticed that the fix to avoid returning the "settings" values is...
> TBH I'm not knowledgeable about how it is supposed to work. I would think the check makes sense, but maybe you can elaborate a bit why you think it...
@provokateurin I adapted the `getStoredValue`, but I also had to add some handling to prevent reading, editing and deleting of properties that overlap between the "settings" and "profile" apps ðŸ«
> I fear that you’re gonna break `ignore-missing-user` option. You test in several places if the user exists despite the option value. Also in some places you use the user...