salmanazmat666

Results 10 comments of salmanazmat666

> What if this project was just a docker container. The container is passed some endpoints and protobufs to configure it. You wouldn't need any Java experience, instead relying on...

It seems like if a publish response is pending and all the subscriptions are cancelled, the server doesn't send publish response that the client was expecting. And, upon creating the...

> I also ran into this issue. I found a workaround: > > * creating a dummy subscription, right after connecting the client > > * starting a goroutine constantly...

> I don't think we should mix `tenants` and `providers` up like this, right now, we have a single `provider` configuration, so the intention from previous work was that you...

Hi @JoelSpeed, I have updated the PR to incorporate your comments. Following changes were made 1. Removed the `TenantLoader` interface. Now we have following constructs, ``` // tenantMatcher is responsible...

Hey @JoelSpeed, We have added more features into the PR, 1. fixed unit tests 2. implemented a new tenantloader, that stores provider configs in postgres and uses redis as a...

> Tremendous Job @salmanazmat666 . Do you have any sample config file or instructions to run these changes? For eg. > > * sample tenants.yml file > * How to...

> Hi @salmanazmat666, to make up for my promise of giving this a proper review. I want to ask if you have this version of oauth2-proxy deployed in an environment...

@tuunit I have updated the PR and following are the main things I did, - [x] - Refactoring of naming schema: tenants -> providers - [x] - Refactoring of package...

> Thanks for putting all the work in 🥳 Hey @tuunit , did you get a chance to review the PR ?