Salem

Results 42 comments of Salem

Oh yikes, I'm sorry you're running into that. It does look like this would involve supporting / moving to a 64-bit-based index file. That's not work we have slated, but...

@rfan-debug it's likely something we'll have to do at some point. Are you interested in tackling it?

I think that's part of what makes this issue tricky. If you're willing to write unit or integration tests, I'd definitely welcome that as well.

Hey! We're meeting now and generally like this PR. We have two asks before we merge it: 1. Can you add some tests? 2. Increasing `filePeekSize` might impact startup time....

Hey! Just to clarify, are you proposing that this replaces `ui/bindata.go` and the `go-bindata`package?

Ok, cool. We aren't going to prioritize this for the time being, but we are open to a PR.

Having detailed metrics tracking might be a bit out of scope, but looking into better logging might be on the table in the nearer term.

The original image is owned by Etsy, but this project is no longer maintained by Etsy. We can look into setting up a docker account and publishing a new image.

Thank you for this PR! I'll look it over this weekend. Very excited about this one. Just as a heads up, there's a pending PR to set up go modules...

Hey @elliotpeele, thanks for being patient with us. #353 has been merged. Do you mind updating this PR to use go modules instead?