hound Reload config on update

This PR adds automatic reloading of the configuration file when the file is written. It mostly focuses on updates to the repository list. Resolves #287

Oct 16 '20 03:10 elliotpeele

Thank you for this PR! I'll look it over this weekend. Very excited about this one.

Just as a heads up, there's a pending PR to set up go modules in this repo, which might have implications for how you add fsnotify: https://github.com/hound-search/hound/pull/353

I'll prioritize merging that PR in so that it unblocks this PR, but you'll probably need to move fsnotify once it's merged.

Oct 16 '20 15:10 salemhilal

Hey @elliotpeele, thanks for being patient with us. #353 has been merged. Do you mind updating this PR to use go modules instead?

Oct 24 '20 19:10 salemhilal

I don't mind updating to use modules. BTW, I found an issue with the PR where over time, as the config gets updated, the indexes get removed. I haven't had time to work on a resolution yet though.

Oct 24 '20 23:10 elliotpeele

Got it. I'll hold off on reviewing this until I hear more, just so I can prioritize clearing out some of the outstanding backlog.

Oct 25 '20 02:10 salemhilal

@salemhilal, I finally got back to this. Found why the indexes were getting deleted when the config updated and updated the PR.

Nov 11 '20 05:11 elliotpeele

Thank you @elliotpeele! I'm a little swamped at the moment, but I haven't forgotten about this PR. I appreciate the update and will give it a closer look shortly.

Nov 17 '20 00:11 salemhilal

Hey! Is there any way in which I can help in getting this merged? I know only a little Go and I'm not at all familiar with Hound's codebase, but if it was rebased on top of head I can run this on our test deployment and report any issues!