sakhunzai

Results 6 comments of sakhunzai

I agree with your suggestion to fix [is_if_match_failed](https://github.com/chibisov/drf-extensions/blob/master/rest_framework_extensions/etag/decorators.py#L125). I spent hours having "Precondition Failed" on a `PUT` request. This means both functions require striped etags therefore, they should be done...

I also see another issue with line: ` etags = [etag.strip('"') for etag in etags]` if we have weak etag its not striped properly and matching will fail e.g ```python...

I am not sure what will be consequences given 1.11 [documentation](https://docs.djangoproject.com/en/1.11/topics/conditional-view-processing/#the-condition-decorator) read as: > Changed in Django 1.11: > In older versions, the return value from etag_func() was interpreted as...

yes both are latest : `composer self-update` `composer global require "fxp/composer-asset-plugin:~1.0.2"`

some other observation that might help fix the bug a) A quick fix copying logic from `AssetInstaller` constructor to `Installer\IngnoreFActory::getInstallDir` ``` protected static function getInstallDir(Composer $composer, PackageInterface $package, $installDir =...

@lisachenko the issue in upstream lib is fixed so this issue is also resolved in laminas/laminas-code v4.9.0