Sakher

Results 14 comments of Sakher

Created a branch to add cookies support - can't push a PR it seems.

We have the same issue - would be great if you can update on this. Thanks

I've made the code for generating this eval public to aid with reviewing this PR. https://github.com/sakher/open-ai-quran-eval-generation Thanks in advance!

@andrew-openai @etr2460 @katyhshi Is there anything I can do to help aiding the review of this PR? I appreciate that it is from a domain and a language that can...

> 2. The "ModelGraded" evaluation method isn't suitable for this kind of prompt. That method is used when there is a subjective answer to a prompt. For these evals, the...

@usama-openai - I have done all of the changes and updated the documentation about the results (including the raw results and log files) here: https://sakher.notion.site/Using-OpenAI-Evals-for-Quranic-Text-Evaluation-06d8ca52d22449b4b7ac36f582c312e9 As mentioned earlier, I have...

> The PR looks in good shape now. Kindly keep only evaluation-related changes in this PR and create a new PR for GPT-4o-related changes. Thanks @usama-openai - I removed all...

I have a few evals in mind to add related to Arabic language - but wanted to ensure that they would be valuable and likely accepted before putting the effort...

@usama-openai - the unit tests fail on this PR as well as on `main` (not sure why they are being skipped for some other recent PRs!). I created an issue...

The issue happens when parts is a protobuf object and not a dict - the check needs to be replaced with: ```python if len(parts) != 1 or not hasattr(parts[0], "text"):...