Sai Kishor Kothakota

Results 455 comments of Sai Kishor Kothakota

@tenfoldpaper Maybe what you are looking for is a [`System`](https://github.com/ros-controls/ros2_control/blob/master/hardware_interface/include/hardware_interface/system_interface.hpp) [HardwareComponents](https://control.ros.org/rolling/doc/getting_started/getting_started.html#hardware-components), where multiple actuators can coexist and share information.

> 10 lines are still not covered, and total coverage will decrease. should I try to add tests to run into this failure cases? Sure. if you can, it would...

@christophfroehlich Thanks for helping out and adding very nice tests

> Just let us add some notes about this once #1477 is merged. Sure. I will do that :)

The failing tests are due to the Flake8 issue :)

> It can not load the `JointStateBroadCaster` ` what(): Failed to load library /opt/ros/iron/lib/libjoint_state_broadcaster.so` which is installed from the package repository. > But I guess that is to be expected....

Hello! Earlier to these logs do you see any info about resource successfully initialized the components from the URDF from the topic before the crash?. Can you try using mock...

Ok, based on what you said, can you add the following condition `if (resource_manager_->is_urdf_already_loaded())` at the beginning of the read and write cycles of the resource_manager? and see it it...

Hello @firesurfer ! You can tryout this branch: https://github.com/saikishor/ros2_control/tree/robot_description/crash/iron and let us know.