Bhuwan Sahni
Bhuwan Sahni
cc: @HeartSaVioR PTA, thanks!
cc: @HeartSaVioR PTAL, thanks!
Thanks a lot for the guidance @fpetkovski. Injecting the stats object sounds like a good idea. We would need a mechanism to collect these stats and populate them in the...
I looked further into the suggestion of incrementing stats using a atomic operator @fpetkovski but ran into an issue with incrementing stats in vector and matrix object, specifically with the...
Yeah, no worries @fpetkovski. I updated the PR with changes based on atomic counters. If I exclude the changes in step_invariant.go file (https://github.com/thanos-community/promql-engine/pull/173/files#diff-15039040719a84e49e402377c62ed1606af8f83e9d278e3e2b695b8eacfa90c2) and run the `TestQueriesAgainstOldEngine`, the following tests...
Thanks for your input @fpetkovski. I was a bit tied up last week and could not get to this. The feedback makes sense to me. However, I looked further into...
Thanks @fpetkovski. Your comments make sense to me. The PR got accidentally closed due to GitHub workflow syncing my main branch (apologies for that). > Given that with this implementation...
@fpetkovski I have removed the changes to drain the operators in favor of performance. However, I tried the proposal to `counting samples from the step invariant operator if we can...
Thanks @fpetkovski I will make these changes in the next couple days.
I would like to contribute to adding support for query stats in the engine.