Søren Bjergmark

I have faced same issue but returning null should not be needed? (I know the tests are expecting null, but this can be changed to asserting string.IsNullOrEmpty() - this could...

You are breaking compatibility under all circumstances by returning data where it before returned null. The pull request are also breaking compatibility for success status codes since now the libary...

The LoggerFactory interface is from Microsoft.Extensions.Logging which is for example used with ASP.net Core. The loggerfactory interface is injected using property injection like this: ` new GraphQLFieldBuilder() { LoggerFactory =...

The `WebSocket` class does not have any Connect, however `ClientWebSocket `does have a Connect method. Therefore reconnection should be implemented in `GraphQLSubscriptionWebSocketClient` possible by providing a new event in the...

Eventhandlers should generally don't throw exceptions. But you are right the library should handle the exception instead of just calling OnDisconnected.

Would you create a PR for this change? :)

Yep I think it should not disconnect if the vent handler is throwing an exception. I will work on the disconnection logic in the next weeks - it would be...

I have created a example for you: ``` using System; using System.Runtime.Serialization; using System.Threading.Tasks; using Newtonsoft.Json; using Newtonsoft.Json.Converters; using SAHB.GraphQLClient; using SAHB.GraphQLClient.FieldBuilder; using SAHB.GraphQLClient.FieldBuilder.Attributes; using SAHB.GraphQLClient.QueryGenerator; using SAHB.GraphQLClient.Subscription; namespace LiftStatus...

@ClarenceMG Does it work?

Hello, It's possible to chance the GraphQL field name using an attribute. For example: ``` [GraphQLFieldName("Name")] public string Name { get; set;} ``` Alternavively you can override the method GetPropertyField...