sagudev

Results 148 issues of sagudev

https://github.com/bheisler/criterion.rs is the most popular stable bencher.

In servo (https://github.com/servo/servo/pull/32304) I noticed that test could pass if errors we not caught by scopes (bad scopes impl; but they passed all error scope tests), so it might make...

We should likely turn this on for both MacOS and Linux as well: - https://searchfox.org/mozilla-central/rev/4496b3ed9bb535832e4826f09fbcb645b559a32d/gfx/2d/ScaledFontMac.cpp#473 - https://searchfox.org/mozilla-central/rev/4496b3ed9bb535832e4826f09fbcb645b559a32d/gfx/2d/ScaledFontFreeType.cpp#93 _Originally posted by @mrobinson in https://github.com/servo/servo/issues/33045#issuecomment-2291032347_

From #30504, although redone. Most changes are mechanical and reviewable per commit. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report...

A-content/webgpu

After #32896 lands, we would need some warnings: ``` Compiling fonts v0.0.1 (/home/runner/work/servo/servo/components/fonts) warning: unexpected `cfg` condition name: `ohos_mock` --> components/fonts/platform/mod.rs:36:66 | 36 | #[cfg(all(target_os = "linux", not(target_env = "ohos"),...

B-meta

Currently trait is generated only for methods https://github.com/servo/servo/blob/0672eca7496bd54001e4625f7987d3e4053a3914/components/script/dom/testbinding.rs#L100 it would be nice to generate trait also for static methods and other common methods (like constructors and stuff), so we can...

A-content/bindings

I think this happens because we panic in drop of `OsIpcReceiverSet`, (it's actually panic while panic), but this is in separate thread. While before this was visible rarely (we have...

``` [2024-07-31T17:54:33Z ERROR servo] embedder shouldn't be handling messages after compositor has shut down assertion failed: !cx.is_null() (thread Script(2,3), at C:\Users\runneradmin\.cargo\git\checkouts\mozjs-fa11ffc7d4f1cc2d\3720f6d\mozjs\src\rust.rs:302) [2024-07-31T17:54:33Z ERROR servoshell::panic_hook] assertion failed: !cx.is_null() Segmentation fault ```...

I-crash
P-windows

It was commented out in https://github.com/servo/servo/pull/32769, but we want it back after we also do some changes in mozjs. Also see https://github.com/servo/mozjs/pull/474#issuecomment-2225751703

Currently, this is not possible, because action still tries to find crate in index.