sagudev

webgpu: Move errorscopes to WGPU thread

1

This should lower amount of messages being set to script (no need to send ErrorScopeId and removed useless WebGPUOps::Success), simplified error scope logic and it aligned us with spec (errors...

Error scopes should be handled in device timeline (wgpu thread)

2

Currently they are handled in script thread, which causes problems on some tests now that we have parallel poller. In tests [webgpu:shader,execution,expression,constructor,*](https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,execution,expression,constructor,*) we get very flaky results (sometimes passing test,...

Support crown on windows without hacks

7

We need proper solution for https://github.com/servo/servo/issues/32300. Dylint has some interesting solutions: https://github.com/trailofbits/dylint/commit/c22218107853018a04e01a65a16406612e36186a

See https://github.com/servo/servo/pull/32266#issuecomment-2106129041, we currently do to much unwraps where we should actually handle those with proper error signaling (or warning if more proper).

webgpu: Implement device lost

5

--- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix https://github.com/servo/servo/issues/32347 - [x] There are...

If poller thread is currently running but at the end of execution,[ `poller.wake()`](https://github.com/servo/servo/blob/ff166ea1e3086adb2b5019b31bf51c921e7f151b/components/webgpu/poll_thread.rs#L97) will not woke the thread (it's running) but the next moment it goes to sleep, so `poller.wait()`...

Currently device lost is mostly non-working/missing. We need to resolve lost promise of device using https://docs.rs/wgpu-core/latest/wgpu_core/global/struct.Global.html#method.device_set_device_lost_closure and implement device losing, we also need to take care of https://github.com/servo/servo/blob/9f32809671c8c8e79d59c95194dcc466452299fc/components/script/dom/globalscope.rs#L324 and of...

Investigate ErrorStackFrames in clones

4

According to MDN stack field is non-standard: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack, if this is left in all error clones are failing, but after some investigation I found out that fixing this in servo...

This is required for newer CTS. [`webgpu:api,operation,shader_module,compilation_info:*`](https://gpuweb.github.io/cts/standalone/?runnow=1&q=webgpu:api,operation,shader_module,compilation_info:*) passes. There are some new expectations (they were crashes before). --- - [x] `./mach build -d` does not report any errors - [x]...

Replace null-byte terminated string literals with C-string literals

1

They are available from rust 1.77: https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#c-string-literals, most occurrences should be found by searching for `\0` in source tree. This is generally just mechanical work, but it mostly touches unsafe...