Roy Jacobs

Results 83 comments of Roy Jacobs

You mean if the original object also has a property called `create`? That would certainly be a problem. Maybe we can prefix our options (e.g. `__create: true` in the options...

That's true. Is there a special reason you've separated the two components? Instead of doing just: ``` javascript { : { copy|include|ignore: true|false key|create|update|: } } ```

It's true that they cannot be used all at once. If you 'copy' you can't 'ignore'. But maybe it would be better to call it something like a 'mapping action',...

@DzenisevichK Let's do it in two steps: - First, merge the specific options (the options that you pass into `toJS`) at every level of the tree. This way, the old...

I know, but this is the current behavior of the old code. I would like to release a 2.1.1 version with your fixes so that at least problems such as...

Ok! Please keep me updated :)

Does it work for you in 2.1.0? https://github.com/SteveSanderson/knockout.mapping/blob/f996b65ce93ccb934746fdb581dc2060359f9326/build/output/knockout.mapping-latest.debug.js

At the moment the `options` notation will remain as it is in v2.2, simply because there were too many backwards compatbility issues with the v2.1 release. The new notation might...

@DzenisevichK Btw, I would again like to thank you for all the work you put in and I hope we can find a way to integrate features from your fork...

@steveluscher Actually you shouldn't need to use the `""` property. It should work as you indicate (everything in root-level being moved to the `""` property behind the scenes) so I...