Ben Kimock
Ben Kimock
I _suspect_ that based on the kinds of descriptions here that this is related to colliding incremental builds. What jumps out at me is that you are writing to `target/debug/gn_out/obj/librusty_v8.a`,...
> Hm. If it is incremental, then shouldn't we be validating the hashes...? The hash _of what_ though. This build script is scribbling a file it's acquired from elsewhere into...
This is loop unrolling. So... > I expected to see this happen: Assembly composed of `cmov` and/or `adox` instruction. Or at least `mov` + `je` to a single exit branch....
@GrigorenkoPV The PR description makes it look like this PR is very incomplete. This PR description will become part of the commit history of the repo when the PR is...
CI passed. Phew. I was afraid these were somehow used for some complicated setup CI uses.
Ah! Yes your Zulip thread is exactly why I was thinking about this.
Little race condition. While re-reading the code I realized why the macro above doesn't need special treatment: It does ``. So I just imitated that in the u128 code. I...
@bors r=tgross35
I cannot reproduce this panic. I think you over-minimized your example to something that doesn't provoke the bug.
I believe `noalias` has been associated with `Box` since https://github.com/rust-lang/rust/pull/11538. Note that the justification given at that time was ``` // `~` pointer parameters never alias because ownership is transferred...