Ben Kimock comments

Results 346 comments of


                                            Ben Kimock

Tweak some attributes to improve panic_immediate_abort

@bors retry

const-eval: do not make UbChecks behavior depend on current crate's flags

I'm not surprised we get away with no perf hit; unsafe const code is pretty rare to begin with. And the one regression has a significance factor of 1.15x so...

const-eval: do not make UbChecks behavior depend on current crate's flags

@bors retry

const-eval: do not make UbChecks behavior depend on current crate's flags

@bors rollup=iffy

miri weak memory emulation: put previous value into initial store buffer

I'll review this today, that's how we will proceed :p

miri weak memory emulation: put previous value into initial store buffer

I have a question about the implementation, but it's just idle curiosity. Thanks for the reminder. @bors r+

High failure rate on Windows MSVC CI with filesystem errors

Another: https://github.com/rust-lang/rust/pull/128982#issuecomment-2295068323

Compile-time semantics of ub_checks intrinsic are unsound

I previously suggested something like option 1 but @RalfJung asked that I not do that in https://github.com/rust-lang/rust/pull/121662#discussion_r1508190417. I don't care very much whether these checks are enabled in Miri or...

rust compile error

@rogelx How did you run into this ICE? What were you compiling?

rust compile error

I'm pretty sure that crash is caused by an archive file being overwritten or modified while the compiler is interacting with it. The reason the crash looks funny is that...