Brennan Saeta

Results 22 comments of Brennan Saeta

This is a follow-up to https://github.com/saeta/penguin/pull/30

This relates to umbrella issue: https://github.com/saeta/penguin/issues/33

Switched from `Sequence` to `Collection`. It's an interesting point in design space. As alluded to, I'm somewhat skeptical that we're getting appropriately efficient operations by default. (e.g. `Sequence.prefix` avoids redundant...

@dabrahams aside from our discussion on `Sequence` vs `Collection`, do you have further changes you'd like to see?

Whoops, looks like your additional comments raced with me fixing & pushing the fixes! PTAL?

https://github.com/saeta/penguin/issues/33

From [console output](https://github.com/saeta/penguin/pull/111/checks?check_run_id=994726172), the compiler version provided by Ubuntu / GitHub on Linux is: ``` Run swift --version Swift version 5.2.5 (swift-5.2.5-RELEASE) Target: x86_64-unknown-linux-gnu ``` And for macOS it's: ```...

@dabrahams Thanks for asking! I have a number of things I want to add (e.g. `RandomAccessCollection` conformance, `MutableCollection` conformance, etc), but the basics of the new `Deque` implementation should be...

One question for you I have is: I'm not sure how to satisfy both the requirements for `Index` on `BidirectionalCollection` (in particular, comparison between `Index`es) as well as the design...

https://github.com/saeta/penguin/pull/29, https://github.com/saeta/penguin/pull/30, https://github.com/saeta/penguin/pull/32