Sadhan Sood
Sadhan Sood
Thanks @huitseeker, also left a doc string on WorkloadSpec. I like your comment. Thanks
@laura-makdah if I understand you correctly what you are describing actually seems more convoluted for the end user than the api's proposed in this diff. Also, there is no hard...
Let me address the remaining comments and send it for another review, thanks @akichidis
@akichidis addressed your comments, thanks!
The certificate is still executed like the test proves but we don't need to wait for it on the client, no?
> Yeah I think this is the right thing to do. My only question is whether this test is reliable? i.e. is one yield guaranteed for the server side to...
I also moved `sync_certificate_to_authority` to run in a tokio task so that we don't abort the syncing process mid way once we have enough votes. Note: this function is invoked...
I looked at the code in batch service again and it seems like this is not really a problem: ```// Always stop at low watermark guarantees that transactions are //...
Oh damn, that is right. Here is an alternate proposal which is some work: we add another table called lagging_executed_sequence which has committed txns get appended whose assigned_seq_num < proposed_seq_num...
Sure thing, let me send that out as a different PR while we keep the discussion ongoing here. Here it is https://github.com/MystenLabs/sui/pull/5504