Sachin D. Shinde

Results 12 issues of Sachin D. Shinde

`extendSchema()` doesn't set `GraphQLSchema.description` if the `schema` definition is in the input `GraphQLSchema` instead of the AST. **Example** Running this code: ```typescript import { buildSchema, extendSchema, parse } from "graphql";...

**Description** When an object type is `@inaccessible` and is used in a fragment-nested `@requires`, it can cause Fed 2 composition to throw. (To be clear, I'm not sure what the...

**Description** Somewhat similar to https://github.com/apollographql/federation/issues/1866, when using `@requires`, Fed 1 gateway can give the wrong selection set to the requiring subgraph (it seems to query the right data from the...

The code for `ResampleOp.resample()`, when working with source images that have premultiplied alphas, doesn't ensure destination color samples are clamped to the alpha value. This can result in other ImageIO...

Trouble-shooting

While trying to add some code to the `didResolveField` handler of `ApolloServerPluginUsageReporting`, I noticed some issues: - It looks like `didResolveField` is executed in a dangling promise created in `whenResultIsFinished()`,...

🔌 plugins

This PR is a followup to https://github.com/apollographql/router/pull/5378 . In that PR, removing this wrapping closure triggered 46 router tests to fail specifically on macOS with the message `'GraphQL endpoint exposed'...

In trying to prevent infinite loops, https://github.com/graphql/graphql-js/pull/3442 introduced a bug that causes certain violations of the [Field Selection Merging](https://spec.graphql.org/draft/#sec-Field-Selection-Merging) validation to not be caught (released in `16.3.0`, and backported to...

This PR updates context-matching logic for `@context`/`@fromContext` to use earlier edges in the `GraphPath` if possible. (Also a bit of logic reorganizing for performance reasons.) Specifically, if there are key...

This PR fixes two bugs in the satisfiability code when the subgraph type differs from the supergraph type due to output type covariance: 1. It now handles no-op inline fragments...

This PR updates satisfiability logic to use a (heap-based) priority queue instead of a stack to store validation state, where a state is higher priority if it has less possible...