Dmitry Cherniachenko

Do not show "Open in GitHub" menu item when IDEA does that already

1


`failNotSame` message could emphasize reference equality

3

When calling `assertSame` for two different instances of identical objects the failure message will be quite confusing: "expected same: was not:". See https://github.com/junit-team/junit4/blob/8c9e81daf38efa8b4af9ba5c55fe83765ac434d6/src/main/java/org/junit/Assert.java#L829 I think the clarity could be improved...

Asserts for CharSequence contents

13

A lot of APIs in Android deal with `CharSequence`. And using `assertEquals()` with `CharSequence` arguments is cumbersome and unstable. One has to reproduce the exact same type which might change...

[Feature request] Tabs opened from a (compact) pinned tab should appear at the bottom

8

Currently new tabs opened from a (compact) pinned tab appear at the very top of the tab sidebar. IMO it is not very consistent behavior as usually the top tabs...

This would make it easier to navigate all those otherwise very similar entries. BTW, currently the entries emphasize the method too much, IMO. And the URL (which is more important...

Folding range checks into "in [...]" loses closing bracket sometimes

3


Wrong folding of the ternary operator

1

 Or is it some special (Kotlin?) syntax when "Elvis" condition can be a part of a bigger expression?

I grew to realize I am not very much in favor of the way interpolated Strings are folded by the plug-in. More often than not it makes the code more...

 The best folding here IMO would be the following: ``` IGNORED_FULLTEXT_SOURCES += settings.getString(key).split(VALUES_SEPARATOR).map(Integer::valueOf); ```

 In this particular case (when index = 0) the best folding is probably this: `vCharSequence = sequence + vCharSequence;` In case the index is different from 0 I don't...