Sebastian Schreiber
Sebastian Schreiber
@simonschaufi Would like to close this issue. No reaction anymore. Feel free to reopen.
I would merge it. Deployer is doing the same but adds a pre-check before. @jonaseberle Could you add a pre-check before like deployer does: https://github.com/deployphp/deployer/blob/master/recipe/deploy/shared.php#L41
@simonschaufi I am going to close this issue. Feel free to reopen.
Would you like to investigate more and fix this issue? Would be awesome, because i have no real setup to reproduce and fix this issue. Thank you.
@SvenJuergens I have also no idead what is safe here. Could you show me your configuration file, so i can see if it a miss configuration. I am lost, sorry.
Could you close the issue
I am gonna fix the tests
Everything seems fine. The failing test is unrelated to your change. I am not sure but the database connection is fragile from time to time so the functional tests are...
Oh. I thought it was related to the other Pull Request. In that case you should do a Pull Request first. Then i can see the failing tests here
@tomasnorre Thanks Tomas. I have updated PHPStan and Rector and the errors are gone.