Abdelhafidh Belalia
Abdelhafidh Belalia
@abzokhattab Thanks for the update. The RCA is correct. Regarding the solution, the failing tests should be addressed (not all of them need to be updated - some are actually...
@tienifr Thanks for the update. I found this edge case failing, not sure if it's worth addressing ``` > # h1 > b > c ``` Regardless the solution seems...
@abzokhattab Thanks for the update. Unfortunately the solution is too complex (more regex and more loops).
@tienifr I would still prefer to avoid any additional regex. The trim was added as a feature (unwanted feature it appears). Removing that functionality should not increase the complexity.
@badeggg Thanks for the proposal. Your RCA is correct. The solution looks good to me 👍. We don't have any specific indent size, we can just limit the leading trim...
@Julesssss Please assign me as C+ here as well
I have only added videos for Web. Let me know if I need to include the rest
@c3024 I don't think this needs a C+ review
cc @marcaaron
In our use case, we need to use `getImage` because using `getImagePNG` for JPEG is slower | Copying as JPEG | Copying as PNG | |:---------------:|:--------------:| | | |