Abdelhafidh Belalia
Abdelhafidh Belalia
@bernhardoj Ah I see, we have multiple similar bugs. The RCA and the solution for the bug you mentioned make sense to me. But let's not update the `total`, as...
@robertjchen Please note that we have two bugs reported here. The bug reported in the "Action Performed" section is FE and @bernhardoj's solution above will fix it. However the bug...
- The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/42573 - The offending PR has been commented on: https://github.com/Expensify/App/pull/42573#discussion_r1777020766 - A discussion in #expensify-bugs has been started : Not...
@bernhardoj I just found out we sum up the hold transactions values without taking into account their currency. This causes wrong value calculation if we hold multiple expenses with different...
@bernhardoj Will that approach be enough to make it work? I see this line that gets the currency based on the first hold transaction https://github.com/Expensify/App/blob/b5a0a2967635d117506e3dc4c1b78139d0d17b44/src/libs/actions/IOU.ts#L6457 If the first transaction currency...
@nkdengineer Thanks for the proposal. Your RCA is correct. Regarding the solution, can we use `SelectionList` instead? It should cover both `SafeAreaConsumer` and `ScrollView`.
@nkdengineer Can you elaborate? How come only the header is visible? You should be able to make it work. If not, can you explain the problem?
@Expensify/design How is the account switcher list supposed to look when the list contains too many accounts? Currently it's broken, no safearea consideration, the list is not scrollable and the...
PR deployed to production 2 weeks ago. This is awaiting payment