Abdelhafidh Belalia
Abdelhafidh Belalia
@rlinoz Ah cool! Then we should either hold this on https://github.com/Expensify/Expensify/issues/341000 or just close it
@strepanier03 I don't have access to the Expensify repo. Maybe @rlinoz can take a look?
Will see if it's convenient doing so for now, an alternative solution is to combine the cap files into one using tools such as `mergecap`
can you share the capture file?
I need the capture file to reproduce the issue. Verify that you are using the correct extension .pcap or .pcapng
The problem is that the [created layout](https://github.com/facebook/react-native/blob/7211119d2325a67067f9dd7296cdcb9f91624c7f/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java#L448-L466) renders the text with line break enabled and what we end up measuring is just the first line which does not include all...
The suggested solution causes a regression since all Texts with `numberOfLines={1}` will take full width | Before | After | |:------:|:-----:| | | | ```tsx 1{'\n'} ```
The easiest solution that come to mind is to compare the layout's number of lines (`layout.getLineCount()`) with the specified `numberOfLines`, if it's greater, then the text is wider than the...
An alternate solution is to render the text without line break ([setLineBreakConfig](https://developer.android.com/reference/android/text/StaticLayout.Builder#setLineBreakConfig(android.graphics.text.LineBreakConfig))) but I got the app crashed trying to work with this one. Edit: This won't fix the problem...
Test case that this PR fixes: `**text**abc` Expected results: `text` to be in bold