[HOLD #34692] [VIP-VSB] [$500] Web - Task - Empty user shows up on share somewhere list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.41.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4311499 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/a/14931991
2. Click on Message with share code tests
3. Click on FAB > Assign tasks > Give title > Click on share somewhere
4. Observe the list of users

Expected Result:

Share code tests account should be shown with its avatar and its name

Actual Result:

Share code tests account shows up with an empty name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/3e0a2c01-fb1f-445c-a61d-71223d254bb3

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f4ea28196d6fab
• Upwork Job ID: 1757775322633478144
• Last Price Increase: 2024-02-14

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f4ea28196d6fab

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot[bot]]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related #vip-vsb CC @quinthar

[strepanier03]

Repro'd

[Tony-MK]

@s77rt, I believe this issue is related to https://github.com/Expensify/App/issues/35679.

[s77rt]

🎀 👀 🎀 Internal. User initiated reports have empty visibleChatMemberAccountIDs. When you start a chat with a new user or a new group I expected visibleChatMemberAccountIDs to be same as participantAccountIDs.

[melvin-bot[bot]]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bondydaa]

tested again since we've had a few new releases since it was created and am still able to reproduce

[bondydaa]

@s77rt can you link to where the API call is made that isn't properly returning visibleChatMemberAccountIDs so I can try and track down exactly where or what might have changed?

[melvin-bot[bot]]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[s77rt]

@bondydaa It's OpenReport (also related to notificationPreference)

https://github.com/Expensify/App/assets/16493223/06f1b05f-c18d-4377-85ae-439e1ba3bff8

[s77rt]

@bondydaa Did you mean to assign an internal engineer here?

[bondydaa]

oh we're discussing internally to get it prioritized and on someone's plate so it's fine to leave it unassigned from an internal engineer for now

[melvin-bot[bot]]

@strepanier03, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

Thanks @bondydaa - I'll keep following along for updates.

[melvin-bot[bot]]

@strepanier03 @s77rt this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[strepanier03]

@bondydaa - Any update on the internal discussion?

[bondydaa]

hmm interestingly I came across this PR that was merged & deployed back in December 2023 which looks like it's made it so that OpenReport is returning the same thing for both visibleChatMemberAccountIDs and participantAccountIDs

https://github.com/Expensify/Web-Expensify/pull/40002/

So it seems like the API returns these properly.

I noticed in the video from https://github.com/Expensify/App/issues/36492#issuecomment-1953272962 that you were offline first so is it possibly something with some optimistic data on the client getting set incorrect at first?

[bondydaa]

cc @rlinoz maybe you might have some insights here since you wrote that PR, I don't think you did anything wrong in it I'm just a little lost here.

[melvin-bot[bot]]

@strepanier03, @s77rt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rlinoz]

Maybe this got fixed in the last deploy? Or am I doing something different? https://github.com/Expensify/App/assets/5201282/f7183357-4094-4649-b977-69fca833cbcf

[s77rt]

@rlinoz Indeed for that case it seems fixed, I'm getting both participantAccountIDs and visibleChatMemberAccountIDs as expected.

However for the case described here https://github.com/Expensify/App/issues/36492#issuecomment-1953272962 still facing same bug

I think we should have visibleChatMemberAccountIDs same as participantAccountIDs when initiating a new chat / group, right?

[rlinoz]

It should, yes.

But for this other issue that seems to have the same root cause we decided to wait for some refactoring that is happening on participants

[s77rt]

@rlinoz Ah cool! Then we should either hold this on https://github.com/Expensify/Expensify/issues/341000 or just close it

[rlinoz]

Let's hold on that

[strepanier03]

Got it, thanks all.

[strepanier03]

Hold PR still open.

[strepanier03]

@s77rt - I noticed the PR this was deployed and closed for another GH that is currently on hold, https://github.com/Expensify/Expensify/issues/383292.

Can you take a quick peek and confirm that I should update the title for our GH to be on hold for 383292 now? I believe it is based on the fields that GH is going to be removing.

[s77rt]

@strepanier03 I don't have access to the Expensify repo. Maybe @rlinoz can take a look?