Sloane Hertel

Results 169 comments of Sloane Hertel

I like this but it seems like it will break any third party modules using null as a choice and relying on it being a string. It looks like there...

It's on my radar but I haven't figured out the AWX tests yet. If someone wants to take over or push to my branch, please feel free to beat me...

@jnm27 I haven't been able to reproduce this. I tested with your playbook as-is, and then modified it to run for many hosts to try to increase the chance of...

@jnm27 Thanks for the prompt response. How did you ensure the wrong include would cause failure when you ran it overnight? I do see output like `included: test.yml for [hostA,...

@jnm27 Thanks for sharing the playbook. I modified it a bit but it fails irregularly quite frequently - here is one of those failures https://gist.github.com/s-hertel/9b033150e47c5ec7c2054930248b7496. Would you be able to...

Here's a minimal diff that seems to fix the issue for me on 2.13.3: ```diff diff --git a/lib/ansible/playbook/role/__init__.py b/lib/ansible/playbook/role/__init__.py index 7e3511fc40..386ef0b6d4 100644 --- a/lib/ansible/playbook/role/__init__.py +++ b/lib/ansible/playbook/role/__init__.py @@ -558,6 +558,7 @@...

@sourcedelica I'm not sure this is a bug. The timeout applies per task execution. All three attempts are made for your first test case since each lasts less time than...

The behavior is b, the timeout fails an individual attempt. > My tests showed that both did not happen. > a. It never timed out - the max number of...

@sourcedelica It doesn't seem like a bug in my opinion. It seems like you want the sequence of events to be: ```yaml - timeout is 15 seconds - task execution...

@sivel Oh, maybe it was just a flaky CI error in that case.