Sloane Hertel

Results 169 comments of Sloane Hertel

I bisected this issue > lib/ansible/modules/_apt_repository.py:0:0: invalid-documentation: DOCUMENTATION.deprecated.removed_from_collection: extra keys not allowed @ data['deprecated']['removed_from_collection']. Got 'ansible.builtin' to 00ddc27d69624f4c70cc7dacb2d0f311a84863e9. I added my suggested fix for it in #86258 since it has...

There's an old issue open for this too https://github.com/ansible/ansible/issues/35086. I have a one-line change that makes unreachable hosts start at the next play https://github.com/ansible/ansible/pull/78075. I think the documentation (for non-unreachable,...

I think the unreachable resurrection behavior could be intuitive for the free strategy, though it's clearly wrong for linear. The documentation was added very recently (https://github.com/ansible/ansible/commit/319dca2ea8b7ca3d3dbf003ee592cbdba308dfc6), and it's misleading (at...

> Wonder "how to use the from the plugin itself"? You are, but the deprecation for those two options is a bug (and too late to fix I think, given...

Ideally this would have at least one more core reviewer before being merged.

@Dule-martins correct, docs issues should have the label `docs`.

The summary is misleading, but I think the rest of those are in ansible.netcommon now. Didn't check for all, but guessing still unfixed https://github.com/ansible-collections/ansible.netcommon/blob/main/plugins/connection/libssh.py#L94-L102. This fixes the ansible-core portion of...