Phil Coval

Results 469 comments of Phil Coval

Maybe you'll be interested in: https://github.com/EnotionZ/GpiO/issues/42

Please rebase and send cleanup patches separately.

Thx, Please preserve current style, or send a patch that just reindent (using clang-format?) current sources and then add a feature patch on it

Please try to split this change is smaller PR

Is there any interest to upstream this for next release ?

Maybe you can try to demonstrate this by controlling on board leds : ie emulate actions in: /$dir/sys/class/gpio/gpio35 would be forwarded to: /sys/class/leds/led0/brightness does it make sense ?

what open is supposed to return here ? an array of gpio instance (to be closed using close() ) ?

If project uses modern javascript, I might consider to fork it into gpio-lite or some other name to tend to be compatible with current IoT.js API. Or rebase on @evanxd...

FYI, I'd like to have a node implementation of this API: https://github.com/Samsung/iotjs/blob/master/docs/api/IoT.js-API-GPIO.md Then app will be 100% portable between node and iotjs runtimes. we're not that far, just deprecate gpio.export...

Thx it's nicer to read I would at least add a config and callback object to open like: ``` open( { pin: 42, direction: GPIO.DIRECTION,OUT } , function(err,...) { if(!err)...