gpio icon indicating copy to clipboard operation
gpio copied to clipboard

add option to modify gpio base path for testing purposes

Open sa-linetco opened this issue 7 years ago • 9 comments

sa-linetco avatar Jun 21 '18 12:06 sa-linetco

Maybe you'll be interested in: https://github.com/EnotionZ/GpiO/issues/42

rzr avatar Jul 05 '18 19:07 rzr

Please rebase and send cleanup patches separately.

rzr avatar Jul 10 '18 19:07 rzr

@rzr there you go :)

sa-linetco avatar Jul 11 '18 06:07 sa-linetco

Thx, Please preserve current style, or send a patch that just reindent (using clang-format?) current sources and then add a feature patch on it

rzr avatar Jul 11 '18 07:07 rzr

From a software design perspective, I think it makes more sense to set the base directory path on the class method. On an instance level, the test option should be the filename which contains the value rather than the directory.

Also this is probably unintentional but the entire package.json file is overridden which may cause reference problems when it's publish in npm.

EnotionZ avatar Jul 12 '18 19:07 EnotionZ

Please try to split this change is smaller PR

rzr avatar Jul 26 '18 09:07 rzr

Is there any interest to upstream this for next release ?

rzr avatar Aug 01 '18 10:08 rzr

Maybe you can try to demonstrate this by controlling on board leds : ie

emulate actions in: /$dir/sys/class/gpio/gpio35

would be forwarded to: /sys/class/leds/led0/brightness

does it make sense ?

rzr avatar Aug 27 '18 09:08 rzr

@rzr I think I see where you're getting at - it's like rather than (or in addition to) having a direct path, developers can specify a more powerful mapping. I like it, should be considered in #51.

EnotionZ avatar Sep 27 '18 21:09 EnotionZ