Ry Wiese
Ry Wiese
@CadeMichael btw, I added a `toByteArray` function to this file, so I would maybe suggest renaming `toBytes`/`fromBytes` to `toByteList`/`fromByteList` so that all byte conversion methods are explicit abt what collection...
> Point { ... } seems like a combination of tag and record. Just curious - what does an immutable struct add that can't be expressed with an enum and...
> Regards the final line, I think that this signature more uniformly conveys that two kinds of error can happend `Result[Either[IoError, EofError], Int32]` Hm but EOF is really success termination,...
Something i've realized is that java doesn't make formal guarantees about the number read being less than the number requested. It is legal for the read function to not fill...
Yes we can go that route too
@jaschdoc it's ready now! i think I addressed everything
This should be ready for final review, I've made all the requested changes :)
> Looks good. Maybe you can remove the imports from the `TestReader` module :) > > ``` > use TestReader.mkTestBufReader > use TestReader.fromArray > ``` Done
@magnus-madsen Yes, I think review and merge. It's a stepping stone. With the plan i've proposed, this code would be changed to be written in terms of a generic type...
@magnus-madsen 1. > BufReader struct thingy that wraps anything with a Reader instance Is it possible to add this constraint to the enum def itself? I wouldn't think so... like...