Rebecca Taft

Results 23 comments of Rebecca Taft

Downgrading this to P-3 based on the previous comment.

We have some customer requests to get this done in 23.2

The RFC may be helpful too: https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20220126_partial_statistics_collection.md

And the most recent QA: https://gist.github.com/rytaft/0798b8d2fc7db3d1a0a097c001cece1b

*[`pkg/ccl/testccl/sqlccl/explain_test.go` line 74 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/129843#-O5RDLbu8q1AfbQsxTeu:-O5RDLbv8UVxDitHk68x:b4yb4eu) ([raw file](https://github.com/cockroachdb/cockroach/blob/8e641aba27014642460b372f86a57fd97627b1d9/pkg/ccl/testccl/sqlccl/explain_test.go#L74)):* > ```Go > setup := sqlsmith.RandTablesPrefixStringConsts(rng, pii) > setup = append(setup, "SET CLUSTER SETTING sql.stats.automatic_collection.enabled = off;") > setup = append(setup, "SET CLUSTER...

Not sure why this was added back to SQL Queries. Removing it from our board since it looks like the DRP team is working on it.

Hi @csgourav -- the issue description says "it might require to have sessions that are running for weeks and only close when the nodes restart." So ideally we'd want the...

> @rytaft , we can change the workload configuration with --max-conn-lifetime=168h, which is 1 week. @nameisbhaskar that sounds good, although as noted in [the issue description](https://github.com/cockroachdb/cockroach/issues/122155#issue-2236405901), testing for connections lasting...

Great work!! I didn't review all the code in detail since I think the original PR was reviewed carefully, but I did add a couple suggestions for things that might...